Add statically typed color representation #171
Conversation
docs/2_3_range-plots.fsx
Outdated
| @@ -52,8 +52,8 @@ let range1 = | |||
| Chart.Range( | |||
| x,y,yUpper,yLower, | |||
| StyleParam.Mode.Lines_Markers, | |||
| Color="grey", | |||
| RangeColor="lightblue") | |||
| Color = Color.ColorString "grey", | |||
There was a problem hiding this comment.
Shouldn't it be called Color.fromString for consistency?
There was a problem hiding this comment.
True. Thanks for the hint.
docs/1_3_shapes.fsx
Outdated
| @@ -47,8 +47,8 @@ multiple shapes at once. | |||
|
|
|||
| open Plotly.NET.LayoutObjects | |||
|
|
|||
| let s1 = Shape.init (StyleParam.ShapeType.Rectangle,2.,4.,3.,4.,Opacity=0.3,Fillcolor="#d3d3d3") | |||
| let s2 = Shape.init (StyleParam.ShapeType.Rectangle,5.,7.,3.,4.,Opacity=0.3,Fillcolor="#d3d3d3") | |||
| let s1 = Shape.init (StyleParam.ShapeType.Rectangle,2.,4.,3.,4.,Opacity=0.3,Fillcolor= Color.fromWebColor "#d3d3d3") | |||
There was a problem hiding this comment.
I would leave out the distinction between "webcolor" and hex and merge them, adding a check if the string starts with a #
There was a problem hiding this comment.
True. It is actually the same. I removed fromHex...
There was a problem hiding this comment.
Sorry for not being clear, but I would rather name both fromHex, this would be the naming web devs would expect when creating colors from hex strings. The name fromWebColor implies that things such as "grey" or "aquamarine" should work as well. So fromWebColor should either accept both hex and standard web color strings, or be renamed to fromHex
This PR adds support to statically typed color representation. Warning: Introduces breaking changes.
However, you still can use Colors from Plotly string by Color.ColorString "red"
Fixes #138
Fixes #124